Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap L51 and L50 #198

Closed
wants to merge 1 commit into from
Closed

Swap L51 and L50 #198

wants to merge 1 commit into from

Conversation

SeverS
Copy link

@SeverS SeverS commented Oct 14, 2023

Fixes #157 by swapping the lines L51 with L50.

Minimal repro repository:
https://github.com/SeverS/single-spa-react-repro
gh-pages : https://severs.github.io/single-spa-react-repro/

As you can see on gh-pages, the Button parcel works as expected when it's mounted inline but when you click it the modal which is using appendTo throws an error (check console)

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2023

⚠️ No Changeset found

Latest commit: 6241131

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SeverS SeverS closed this Oct 14, 2023
@SeverS SeverS deleted the patch-1 branch October 14, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel appendTo appears to be broken
1 participant