Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Replace CXX17FLAGS with CXX20FLAGS #3393

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jdblischak
Copy link
Collaborator

Not important, but I noticed this use of CXX17 earlier this week and wanted to fix it before I forgot about it

xref: #3154, #3352

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.27%. Comparing base (cd1e487) to head (5f1780b).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (cd1e487) and HEAD (5f1780b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cd1e487) HEAD (5f1780b)
python 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3393       +/-   ##
===========================================
- Coverage   85.79%   56.27%   -29.53%     
===========================================
  Files          55       84       +29     
  Lines        6176    11525     +5349     
  Branches        0     1068     +1068     
===========================================
+ Hits         5299     6486     +1187     
- Misses        877     4663     +3786     
- Partials        0      376      +376     
Flag Coverage Δ
libtiledbsoma 56.27% <ø> (?)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 50.91% <ø> (∅)

@jdblischak jdblischak merged commit 0ce5ac9 into single-cell-data:main Nov 27, 2024
7 checks passed
@jdblischak jdblischak deleted the r-ci-cxx20 branch November 27, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants