Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Use valid ASCII for wide-as-possible string current domain #3367

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Using "\xff" causes issues in TileDB-Py's tiledb.schema.dump, and is unnecessary regardless.

Notes for Reviewer:

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (58f92e5) to head (4a1e75e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3367      +/-   ##
==========================================
+ Coverage   85.86%   86.06%   +0.20%     
==========================================
  Files          57       56       -1     
  Lines        6210     6116      -94     
==========================================
- Hits         5332     5264      -68     
+ Misses        878      852      -26     
Flag Coverage Δ
python 86.06% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.06% <ø> (+0.20%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@johnkerl johnkerl merged commit 6c26800 into main Nov 22, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/ff7f branch November 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants