[python] Update Scene add_* methods
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename `add_*` -> `add_new_*` for consistency with `Collection` methods. * Change type specific keywords to be `**kwargs` and refer to class create methods for specific keywords.
jp-dark
requested review from
aaronwolen and
johnkerl
and removed request for
aaronwolen
johnkerl
changed the title
add_* methodsScene add_* methods
johnkerl
approved these changes
Oct 16, 2024
This parameter is already a keyword arugment in the spatial `create` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_*->add_new_*for consistency withCollectionmethods.**kwargsand refer to class create methods for specific keywords.