Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Support errLogToConsole from gulp-sass #38

Closed
wants to merge 1 commit into from
Closed

Support errLogToConsole from gulp-sass #38

wants to merge 1 commit into from

Conversation

leevigraham
Copy link

https://www.npmjs.org/package/gulp-sass has a errLogToConsole option:

If you pass errLogToConsole: true into the options hash, sass errors will be logged to the console instead of generating a gutil.PluginError object. Use this option with gulp.watch to keep gulp from stopping every time you mess up your sass.

I've implemented the same functionality in this PR.

First gulp plugin contribution so the implementation style might not be correct. :)

https://www.npmjs.org/package/gulp-sass has a errLogToConsole option:

If you pass errLogToConsole: true into the options hash, sass errors will be logged to the console instead of generating a gutil.PluginError object. Use this option with gulp.watch to keep gulp from stopping every time you mess up your sass.

I've implemented the same functionality in this PR. 

First gulp plugin contribution so the implementation style might not be correct. :)
@sindresorhus
Copy link
Owner

Thanks, but I'm not interested in adding more options. This should be fixed at gulp core level: gulpjs/gulp#359

You're supposed to listen to errors on the stream and handle them the way you want. See the gulp docs.

I've added some logging as people don't seem to get the current gulp error handling.

sindresorhus added a commit that referenced this pull request Mar 21, 2014
since users don't seem to read the docs and understand the current gulp error handling
@leevigraham
Copy link
Author

Fair enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants