Feature/enable multi pool client connections #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview
Packages and Vulnerabilities (35 package changes and 3 vulnerability changes)
Changes for packages of type
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Package | Versionghcr.io/sinadarbouy/gatewayd:905bc10 |
Versiongatewaydio/gatewayd:latest |
|
|---|---|---|---|
| ♾️ | busybox | 1.36.1-r29 |
1.36.1-r28 |
| ♾️ | busybox-binsh | 1.36.1-r29 |
1.36.1-r28 |
| ➖ | ca-certificates | 20240705-r0 |
|
| ♾️ | ca-certificates-bundle | 20240705-r0 |
20240226-r0 |
| ♾️ | libcrypto3 | 3.3.1-r3 |
3.3.0-r2 |
| ♾️ | libssl3 | 3.3.1-r3 |
3.3.0-r2 |
    |
|||
| Added vulnerabilities (1): |
|||
| ➖ | openssl | 3.3.1-r3 |
|
| ➖ | pax-utils | 1.3.7-r2 |
|
| ♾️ | ssl_client | 1.36.1-r29 |
1.36.1-r28 |
Changes for packages of type golang (26 changes)
| Package | Versionghcr.io/sinadarbouy/gatewayd:905bc10 |
Versiongatewaydio/gatewayd:latest |
|
|---|---|---|---|
| ♾️ | github.com/gatewayd-io/gatewayd | (devel) |
0.9.6 |
| ♾️ | github.com/gatewayd-io/gatewayd-plugin-sdk | 0.3.0 |
0.2.15 |
| ♾️ | github.com/getsentry/sentry-go | 0.28.0 |
0.27.0 |
| ♾️ | github.com/go-logr/logr | 1.4.2 |
1.4.1 |
| ➖ | github.com/munnerz/goautoneg | 0.0.0-20191010083416-a7dc8b61c822 |
|
| ♾️ | github.com/prometheus/common | 0.55.0 |
0.53.0 |
| ♾️ | github.com/prometheus/procfs | 0.15.1 |
0.15.0 |
| ♾️ | github.com/redis/go-redis/v9 | 9.5.4 |
9.5.1 |
| ♾️ | github.com/spf13/cobra | 1.8.1 |
1.8.0 |
| ♾️ | github.com/wasilibs/go-pgquery | 0.0.0-20240606042535-c0843d6592cc |
0.0.0-20240510022537-eb0917feddeb |
| ➖ | github.com/wasilibs/wazero-helpers | 0.0.0-20240604052452-61d7981e9a38 |
|
| ♾️ | go.opentelemetry.io/otel | 1.27.0 |
1.26.0 |
| ♾️ | go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc | 1.27.0 |
1.26.0 |
| ♾️ | go.opentelemetry.io/otel/metric | 1.27.0 |
1.26.0 |
| ♾️ | go.opentelemetry.io/otel/sdk | 1.27.0 |
1.26.0 |
| ♾️ | go.opentelemetry.io/otel/trace | 1.27.0 |
1.26.0 |
| ♾️ | golang.org/x/crypto | 0.25.0 |
0.23.0 |
| ♾️ | golang.org/x/net | 0.27.0 |
0.25.0 |
| ♾️ | golang.org/x/oauth2 | 0.21.0 |
0.20.0 |
| ♾️ | golang.org/x/sys | 0.22.0 |
0.20.0 |
| ♾️ | golang.org/x/text | 0.16.0 |
0.15.0 |
| ♾️ | google.golang.org/genproto/googleapis/rpc | 0.0.0-20240711142825-46eb208f015d |
0.0.0-20240528184218-531527333157 |
| ♾️ | google.golang.org/grpc | 1.65.0 |
1.64.0 |
| ♾️ | google.golang.org/protobuf | 1.34.2 |
1.34.1 |
| ➕ | gopkg.in/yaml.v2 | 2.4.0 |
|
| ♾️ | stdlib | go1.22.5 |
1.22.3 |
 |
|||
| Added vulnerabilities (2): |
|||
sinadarbouy
force-pushed
the
feature/enable-multi-pool-client-connections
branch
3 times, most recently
from
04334b8 to
d35c2ab
Compare
Pull Request Test Coverage Report for Build 10134448031Details
💛 - Coveralls |
sinadarbouy
force-pushed
the
feature/enable-multi-pool-client-connections
branch
3 times, most recently
from
016dac1 to
491cad3
Compare
This commit introduces significant updates to enhance the handling of proxies within the server configuration and adds support for load balancing strategies. Changes: - Updated API tests to reflect changes from a single `Proxy` to a list of `Proxies`. - Adjusted initialization and configuration of proxies in `run.go` to support multiple proxies and load balancer strategies. - Updated configuration files to include new fields for multiple proxies and load balancer strategies. - Enhanced global configuration validation for clients, pools, and proxies. - Added new `loadBalancer` section in `gatewayd.yaml` for rules and strategies. - Implemented load balancing strategy selection and Round Robin strategy. - Added tests for load balancer strategies. - Added new error type `ErrorCodeLoadBalancerStrategyNotFound`. - Improved proxy connection handling and added informative comments. Configuration Example: - Updated `gatewayd.yaml` to reflect new support for multiple proxies and load balancer strategies. - Ensure to update your configuration files accordingly. Testing: - Updated existing tests and added new tests for multi-proxy and load balancing functionality. - Verified configuration validation for proxies and load balancers. Impact: - Improved flexibility and scalability of server configuration. - Enabled robust proxy management and efficient load distribution. Update errors/errors.go Co-authored-by: Mostafa Moradian <[email protected]> Signed-off-by: sina <[email protected]> fixed review problems
sinadarbouy
force-pushed
the
feature/enable-multi-pool-client-connections
branch
from
491cad3 to
585ed7f
Compare
- Change pools, clients, and proxies to use map[string]map[string] instead of map[string] - Update related code for compatibility with new nested map structure
remvoed server 2 from gatewatd.yaml file
…iles Updated variable names in the API, test files, run command, and configuration files to improve code readability and maintainability. Key changes include: 1. **api.go**: - Renamed `configurationGroupPools` to `configGroupPools` for clarity. 2. **api_helpers_test.go, api_test.go**: - Updated to use `config.DefaultConfigurationBlock` instead of `config.DefaultPool` and `config.DefaultProxy` for better naming consistency. 3. **run.go**: - Changed iteration variables to `configGroup` and `configBlockName` for better descriptive naming. - Updated logging and error handling to use `configBlockName`. - Modified span attribute naming for tracing proxy creation. 4. **config.go**: - Updated `DefaultPool`, `DefaultClient`, and `DefaultProxy` to `DefaultConfigurationBlock` in the `LoadDefaults` function. - Enhanced configuration parsing logic to handle `DefaultConfigurationBlock` appropriately and ensure robust error handling. 5. **constants.go**: - Renamed `DefaultClient`, `DefaultPool`, and `DefaultProxy` to `DefaultConfigurationBlock`. - Retained other configuration constants for environment prefix, tracer name, and configuration filenames. These changes enhance the codebase by standardizing variable names, improving readability, and making the code easier to maintain.
- Enhanced the Client struct by adding YAML tags to all fields, ensuring compatibility with YAML parsers. - Added YAML tags to the Size field in the Pool struct. - Included YAML tags for the HealthCheckPeriod field in the Proxy struct. These changes address limitations of the YAML parser and ensure proper serialization and deserialization of configuration data.
Co-authored-by: Mostafa Moradian <[email protected]> Signed-off-by: sina <[email protected]>
- Modified the GetServers endpoint to return the current load balancer configuration for each server. - Added a new field "loadBalancer" to the server details, including the load balancer strategy name. - Updated unit tests to validate the new "loadBalancer" field in the API response. - Adjusted test setup to include the default load balancer strategy configuration.
Renamed short variable names used in type assertions to longer, more descriptive names to resolve golint warnings about variable name length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Description
Related PRs
Development Checklist
make gen-docscommand.Legal Checklist