Skip to content

Commit

Permalink
Avoid using the request context for tracing in the GetPools method.
Browse files Browse the repository at this point in the history 
Co-authored-by: Mostafa Moradian <[email protected]>
Signed-off-by: sina <[email protected]>
  • Loading branch information
@sinadarbouy @mostafa
sinadarbouy and mostafa authored Jul 28, 2024
1 parent 9328b80 commit 5bd4f5c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions api/api.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ func (a *API) GetPlugins(context.Context, *emptypb.Empty) (*v1.PluginConfigs, er
}

// GetPools returns the pool configuration of the GatewayD.
func (a *API) GetPools(ctx context.Context, _ *emptypb.Empty) (*structpb.Struct, error) {
_, span := otel.Tracer(config.TracerName).Start(ctx, "Get Pools")
func (a *API) GetPools(context.Context, _ *emptypb.Empty) (*structpb.Struct, error) {

Check failure on line 204 in api/api.go

View workflow job for this annotation

GitHub Actions / Test GatewayD 

syntax error: mixed named and unnamed parameters (typecheck)

Check failure on line 204 in api/api.go

View workflow job for this annotation

GitHub Actions / Test GatewayD 

mixed named and unnamed parameters (typecheck)

Check failure on line 204 in api/api.go

View workflow job for this annotation

GitHub Actions / Test GatewayD 

syntax error: mixed named and unnamed parameters) (typecheck)
_, span := otel.Tracer(config.TracerName).Start(a.ctx, "Get Pools")
defer span.End()

pools := make(map[string]any)
Expand Down

0 comments on commit 5bd4f5c

Please sign in to comment.