Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump simularium-viewer to 3.9.0 #622

Merged
merged 1 commit into from
Dec 9, 2024
Merged

bump simularium-viewer to 3.9.0 #622

merged 1 commit into from
Dec 9, 2024

Conversation

frasercl
Copy link
Contributor

@frasercl frasercl commented Dec 7, 2024

Review time: tiny

Bumps viewer to version 3.9.0, picking up some refactors, part of @interim17's new caching system, and most pertinently, an added hidden control for showing/hiding the bounding box which we've been asked to add ASAP.

@frasercl frasercl requested a review from a team as a code owner December 7, 2024 00:35
@frasercl frasercl requested review from toloudis and meganrm and removed request for a team December 7, 2024 00:35
Copy link

github-actions bot commented Dec 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 67.25% 735/1093
🟡 Branches 66.86% 113/169
🔴 Functions 36.36% 100/275
🟡 Lines 65.67% 656/999

Test suite run success

139 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 527852c

Copy link
Contributor

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's tested, LGTM!

@frasercl frasercl merged commit a0ab8d8 into main Dec 9, 2024
6 checks passed
@frasercl frasercl deleted the feature/viewer-3.9 branch December 9, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants