bug fix: only load drag and drop overlay if drag event contains file #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interim17
requested review from
toloudis and
frasercl
and removed request for
a team
Coverage report
Test suite run success139 tests passing in 8 suites. Report generated by 🧪jest coverage report action from ce8dc56 |
frasercl
approved these changes
Dec 6, 2024
interim17
changed the title
toloudis
approved these changes
Dec 16, 2024
… into fix/empty-drag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
tiny
Problem
Closes #619
Solution
Pretty straightforward fix, check for files before triggering drag and drop overlay.
I've known about this bug but was having trouble reliably reproducing it, finally figured out how to make the bug happen reliably so I chased it down.