styled-components.dropdown menu items #616
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| import React from "react"; | ||
| import { Link, LinkProps } from "react-router-dom"; | ||
| import styled, { css } from "styled-components"; | ||
| import { ArrowRight } from "../Icons"; | ||
|
|
||
| // Dropdown items can be of a few component | ||
| // varieties, including buttons, router links, and | ||
| // anchor tags. This file unifies their styling, | ||
| // and then divides them into three component exports | ||
| // for semantically explicit usage in dropdowns. | ||
|
|
||
| // Common styles | ||
| const baseStyles = css` | ||
| font-family: ${(props) => props.theme.typography}; | ||
|
There was a problem hiding this comment. Does TS pick up that There was a problem hiding this comment. According to intellisense the type isn't I'm not getting a typescript error, do you type props more explicitly in your implementation of There was a problem hiding this comment. I haven't used the There was a problem hiding this comment. It did, and the ThemeProvider is a essentially a context |
||
| background: none; | ||
| border: 2px solid ${({ theme }) => theme.colors.dropdown.background}; | ||
| border-radius: 3px; | ||
| color: ${({ theme }) => theme.colors.dropdown.text}; | ||
| cursor: pointer; | ||
| height: 28px; | ||
| padding: 6px; | ||
| width: 100%; | ||
| min-width: 177px; | ||
| font-size: 14px; | ||
|
|
||
| &&& { | ||
|
There was a problem hiding this comment. && (or here &&&) This is a nice way in https://styled-components.com/docs/basics#adapting-based-on-props |
||
| &:focus-visible, | ||
| &:focus-visible:hover { | ||
| outline: 1.5px solid ${({ theme }) => theme.colors.dropdown.active}; | ||
| border: 2px solid ${({ theme }) => theme.colors.dropdown.background}; | ||
| color: ${({ theme }) => theme.colors.dropdown.activeTextColor}; | ||
| background-color: ${({ theme }) => theme.colors.dropdown.active}; | ||
|
|
||
| svg { | ||
| fill: ${({ theme }) => theme.colors.dropdown.background}; | ||
| } | ||
| } | ||
|
|
||
| &:hover:not(:focus-visible) { | ||
| background-color: ${({ theme }) => theme.colors.dropdown.active}; | ||
| color: ${({ theme }) => theme.colors.dropdown.activeTextColor}; | ||
| border-color: ${({ theme }) => theme.colors.dropdown.active}; | ||
|
|
||
| svg { | ||
| fill: ${({ theme }) => theme.colors.dropdown.background}; | ||
| } | ||
| } | ||
| } | ||
| `; | ||
|
|
||
| const contentStyles = css` | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 8px; | ||
| justify-content: space-between; | ||
| color: inherit; | ||
|
|
||
| svg { | ||
| font-size: 10px; | ||
| } | ||
| `; | ||
|
|
||
| // Styled components | ||
| const StyledDropdownButton = styled.button` | ||
| ${baseStyles} | ||
| ${contentStyles} | ||
| `; | ||
|
|
||
| const StyledRouterLink = styled(Link)` | ||
| ${baseStyles} | ||
| ${contentStyles} | ||
| `; | ||
|
|
||
| const StyledExternalLink = styled.a` | ||
| ${baseStyles} | ||
| ${contentStyles} | ||
| `; | ||
|
Comment on lines
+64
to
+77
|
||
|
|
||
| // Typing for the props of each variant | ||
| interface BaseDropdownItemProps { | ||
| children: React.ReactNode; | ||
| onClick?: () => void; | ||
| className?: string; | ||
| } | ||
|
|
||
| interface ButtonProps extends BaseDropdownItemProps { | ||
| isSubmenuTrigger?: boolean; | ||
| } | ||
|
|
||
| interface RouterProps extends BaseDropdownItemProps { | ||
| to: LinkProps["to"]; | ||
| newTab?: boolean; | ||
| } | ||
|
|
||
| interface AnchorProps extends Omit<BaseDropdownItemProps, "onClick"> { | ||
| href: string; | ||
| newTab?: boolean; | ||
| } | ||
|
|
||
| const getNewTabAttributes = (newTab?: boolean) => | ||
| newTab ? { target: "_blank", rel: "noopener noreferrer" } : {}; | ||
|
|
||
| // Components for use in dropdown menus: | ||
| export const DropdownButton: React.FC<ButtonProps> = ({ | ||
| children, | ||
| className, | ||
| onClick, | ||
| isSubmenuTrigger, | ||
| }) => ( | ||
| <StyledDropdownButton type="button" onClick={onClick} className={className}> | ||
| {children} | ||
| {isSubmenuTrigger && ArrowRight} | ||
| </StyledDropdownButton> | ||
| ); | ||
|
|
||
| export const DropdownRouterLink: React.FC<RouterProps> = ({ | ||
| children, | ||
| className, | ||
| to, | ||
| newTab, | ||
| }) => ( | ||
| <StyledRouterLink | ||
| to={to} | ||
| className={className} | ||
| {...getNewTabAttributes(newTab)} | ||
| > | ||
| {children} | ||
| </StyledRouterLink> | ||
| ); | ||
|
|
||
| export const DropdownAnchor: React.FC<AnchorProps> = ({ | ||
| children, | ||
| className, | ||
| href, | ||
| newTab, | ||
| }) => ( | ||
| <StyledExternalLink | ||
| href={href} | ||
| className={className} | ||
| {...getNewTabAttributes(newTab)} | ||
| > | ||
| {children} | ||
| </StyledExternalLink> | ||
| ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,18 @@ | ||
| .menu-wrapper { | ||
| width: fit-content; | ||
| background-color: var(--dark-theme-dropdown-menu-bg); | ||
| border-radius: 3px; | ||
| padding: 4px; | ||
| } | ||
|
|
||
| .menu { | ||
| background-color: inherit; | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 4px; | ||
| } | ||
|
|
||
| .menu-wrapper .menu :global(.ant-dropdown-menu-submenu-title), | ||
| .menu-wrapper .menu :global(.ant-dropdown-menu-item-only-child) { | ||
| padding: 0px; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is our only styled component for now, but we will probably want to add a
GlobalStylesprovider to get things like basic fonts into all styled components, and it could potentially replace some or all of the global style rules instyle.cssif we do that.