Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop recording icon #610

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: stop recording icon #610

merged 2 commits into from
Nov 13, 2024

Conversation

interim17
Copy link
Contributor

Time estimate or Size

tiny

Problem

Closes #591

class names for icon moon glyphs were not properly applied to the stop-record icon, also noticed positioning was off for both the main icon and the stop icon, so made a couple tweaks

@interim17 interim17 changed the title proper classnames to display stop recording icon fix: stop recording icon Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 66.76% 691/1035
🟡 Branches 66.67% 102/153
🔴 Functions 35.25% 92/261
🟡 Lines 65.11% 614/943

Test suite run success

129 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 26de86e

@interim17 interim17 marked this pull request as ready for review November 6, 2024 22:34
@interim17 interim17 requested a review from a team as a code owner November 6, 2024 22:34
@interim17 interim17 requested review from meganrm and ShrimpCryptid and removed request for a team November 6, 2024 22:34
@interim17 interim17 merged commit 9fe9f69 into main Nov 13, 2024
6 checks passed
@interim17 interim17 deleted the fix/record-icon branch November 13, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird icon for "stop recording"
3 participants