suport safari #569
suport safari #569
Conversation
meganrm
requested review from
toloudis and
tyler-foster
and removed request for
a team
| Safari > Preferences > Advanced and enable | ||
| "Show Develop menu in menu bar".) Then | ||
| please reload the viewer. | ||
| reload the viewer. |
There was a problem hiding this comment.
There were too many 'pleases' in this for me when I read it over, but I can add it back.
There was a problem hiding this comment.
I wouldn't say "please" at all tbh. The fewer words the better.
There was a problem hiding this comment.
I agree, please remove all the instances of the word please. Pretty please with sugar on top.
I wonder if we can link people to Apple to get full instructions on how to enable WebGL2 on older safari.
Coverage report
Test suite run success121 tests passing in 7 suites. Report generated by 🧪jest coverage report action from f210e85 |
| Currently, Simularium supports Firefox, Chrome, and | ||
| Edge. Some features may not work on other browsers. | ||
| Currently, Simularium supports Firefox, Safari, | ||
| Chrome, and Edge. Some features may not work on |
There was a problem hiding this comment.
Super nit: Does the ordering of the browsers matter at all here? If this was ordered by popularity, it would be Chrome -> Safari -> Edge -> Firefox. Could do it alphabetically too.
| choosing Develop > Experimental Features and | ||
| enabling "WebGL 2.0" (If you do not have a | ||
| Develop menu in your menu bar, please first choose | ||
| If using Safari on a Mac and it is not working, |
There was a problem hiding this comment.
Nit: This reads weirdly to me. I'd add something like "If you are using Safari on a Mac and it is not working the content below is not loading", or whatever the expected issue would be.
There was a problem hiding this comment.
@toloudis do you know what the behavior would be if webGl isn't enabled? do they get an error message or is the viewer blank?
There was a problem hiding this comment.
We have a webgl1 fallback from webgl2, but if they don't have WebGL at all that's a huge problem. I have no idea what happens then. I think even webgl2 is supported on well over 90% of devices by now.
| Safari > Preferences > Advanced and enable | ||
| "Show Develop menu in menu bar".) Then | ||
| please reload the viewer. | ||
| reload the viewer. |
There was a problem hiding this comment.
I agree, please remove all the instances of the word please. Pretty please with sugar on top.
I wonder if we can link people to Apple to get full instructions on how to enable WebGL2 on older safari.
Time estimate or Size
How long do you expect it to take a reviewer to review this PR?
xsmall
Problem
closes #567
Solution
Added the version of safari that supports webgl2 and updated the documentation
Type of change
Please delete options that are not relevant.
Steps to Verify:
Screenshots (optional):
current site
