Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump three to r171 #436

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Bump three to r171 #436

merged 4 commits into from
Dec 17, 2024

Conversation

frasercl
Copy link
Contributor

Review time: small (5min)

Bumps three to revision 171, bringing it up to date with the version used in volume-viewer. Removes the deprecated and soon to be removed WebGLMultipleRenderTargets object.

@frasercl frasercl requested a review from a team as a code owner December 11, 2024 01:27
@frasercl frasercl requested review from interim17 and tyler-foster and removed request for a team December 11, 2024 01:27
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.49% 2657 / 10846
🔵 Statements 24.49% 2657 / 10846
🔵 Functions 24.37% 147 / 603
🔵 Branches 81.04% 342 / 422
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/viewport/index.tsx 28.66% 100% 0% 28.66% 116-117, 120-174, 177-240, 243-291, 294-304, 307-396, 529-537, 540-548, 553-579, 582-586, 589-594, 597-601, 604-619, 622-626, 629-673, 676-703, 706-710, 713-717, 720-742
src/visGeometry/rendering/GBufferPass.ts 16.41% 100% 0% 16.41% 48-55, 58-65, 68-69, 72-132
src/visGeometry/rendering/SimulariumRenderer.ts 7.64% 100% 0% 7.64% 76-184, 187-267, 270-271, 273-275, 278-295, 299-300, 303-308, 311-324, 327-336, 339-455
Generated in workflow #511 for commit 9a5aa43 by the Vitest Coverage Report Action

Copy link
Contributor

@interim17 interim17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working and LGTM

The versioning here really is odd, to be an established library on its 171st minor release, but still no 1.0.0

My other comment is just me thinking out loud.

@frasercl frasercl merged commit e8e3589 into main Dec 17, 2024
6 checks passed
@frasercl frasercl deleted the fix/bump-three branch December 17, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants