Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box toggle in tweakpane #434

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Conversation

frasercl
Copy link
Contributor

@frasercl frasercl commented Dec 6, 2024

Time Estimate or Size

small

Problem

There is currently no way to turn the bounding box on/off

Solution

  • Fix existing showBounds method on visgeometry
  • Add a control to tweakpane which calls it

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. npm start and open viewer
  2. Press ctrl+alt+1 to open the secret tweakpane
  3. Toggle new showBounds option on/off

@frasercl frasercl requested a review from a team as a code owner December 6, 2024 23:12
@frasercl frasercl requested review from interim17 and ShrimpCryptid and removed request for a team December 6, 2024 23:12
Copy link

github-actions bot commented Dec 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 42.38% 2160/5097
🔴 Branches
45.12% (+0.09% 🔼)
910/2017
🔴 Functions
38.95% (-0.03% 🔻)
451/1158
🔴 Lines 42.62% 2071/4859
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / index.ts
7.53%
7.26% (+0.12% 🔼)
5.65% (-0.05% 🔻)
7.5%

Test suite run success

144 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 18e96ce

@frasercl frasercl changed the title Feature/bounding-box-tweakpane Bounding box toggle in tweakpane Dec 6, 2024
@frasercl frasercl merged commit 725c733 into main Dec 7, 2024
7 checks passed
@frasercl frasercl deleted the feature/bounding-box-tweakpane branch December 7, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants