Fix/remove simularium engine specific code #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascibisz
requested review from
meganrm and
ShrimpCryptid
and removed request for
a team
ShrimpCryptid
approved these changes
Jun 5, 2024
Comment on lines
-15
to
-21
| const enum PlayBackType { | ||
| ID_LIVE_SIMULATION = 0, | ||
| ID_PRE_RUN_SIMULATION = 1, | ||
| ID_TRAJECTORY_FILE_PLAYBACK = 2, | ||
| // insert new values here before LENGTH | ||
| LENGTH, | ||
| } |
There was a problem hiding this comment.
Why is this enum no longer needed? Is it only used by Simularium engine?
There was a problem hiding this comment.
Correct! Octopus doesn't use this
meganrm
approved these changes
Jun 5, 2024
Co-authored-by: Peyton Lee <[email protected]>
jest coverage report 🧪Total coverage
Show files with reduced coverage 🔻Reduced coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time Estimate or Size
small
Problem
As we fully transition to octopus, it's time to strip out the simularium-engine specific code that is no longer useful
Link to story or ticket
Solution
--octopuscommandline option, as that will now be the assumed platformuseOctopusoption, as that will now be the assumed platformA website PR will need to be made after this, updating their
NetConnectionParamsto removeuseOctopus