Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/add timedata to exports #353

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Fix/add timedata to exports #353

merged 4 commits into from
Dec 5, 2023

Conversation

meganrm
Copy link
Contributor

@meganrm meganrm commented Dec 4, 2023

Problem

I was reviewing the imports from viewer on the website, and this is one that we need but wasn't exported from index.

Solution

export it

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@meganrm meganrm requested a review from a team as a code owner December 4, 2023 21:28
@meganrm meganrm requested review from blairlyons, frasercl, ascibisz, toloudis and interim17 and removed request for a team December 4, 2023 21:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 45.86% 2251/4908
🔴 Branches 44.75% 840/1877
🔴 Functions 43.48% 474/1090
🔴 Lines 45.85% 2143/4673

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

@meganrm meganrm merged commit a6fd9fd into main Dec 5, 2023
6 checks passed
@meganrm meganrm deleted the fix/add-timedata-to-exports branch December 5, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShrimpCryptid ShrimpCryptid ShrimpCryptid approved these changes

@toloudis toloudis toloudis approved these changes

@blairlyons blairlyons Awaiting requested review from blairlyons blairlyons was automatically assigned from simularium/core-devs

@frasercl frasercl Awaiting requested review from frasercl frasercl was automatically assigned from simularium/core-devs

@ascibisz ascibisz Awaiting requested review from ascibisz ascibisz was automatically assigned from simularium/core-devs

@interim17 interim17 Awaiting requested review from interim17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meganrm @toloudis @ShrimpCryptid