fix drag n drop in test viewer #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toloudis
requested review from
meganrm,
interim17 and
ascibisz
and removed request for
a team
jest coverage report 🧪Total coverage
|
|
LGTM, tested with the examples @mogres provided in the slack thread. |
interim17
approved these changes
Nov 8, 2023
Merged
meganrm
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Drag and drop with multiple geometry assets was not working in the testbed viewer.
Solution
The test viewer uses a slightly different code path than the simularium-website viewer for loading from drag and drop. It was checking a data structure in the wrong way, assuming it was an array instead of a keyed object. This resulted in it ignoring the provided geometry files.
(As far as I can tell, this code path is unused by the website client so it should be totally safe. It was needed to debug a different issue with meshes)
Steps to Verify: