Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/orthographic camera ssao #340

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix/orthographic camera ssao #340

merged 2 commits into from
Nov 1, 2023

Conversation

toloudis
Copy link
Contributor

@toloudis toloudis commented Oct 23, 2023

Problem

fixes #329

Solution

The AO parameters needed special consideration for the camera.zoom parameter which is part of the mediation between orthographic and perspective. It will be sent in as a separate parameter so that it doesn't affect other depth-based effects. There can still be a shift in the AO intensity when switching cameras but it's much much more subtle.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@github-actions
Copy link

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 40.14% 1965/4895
🔴 Branches 43.88% 821/1871
🔴 Functions 37.22% 405/1088
🔴 Lines 40.39% 1882/4659

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🔴 src/visGeometry/rendering 40.97% 65.27% 32.23% 41.49%
🔴 SimulariumRenderer.ts 22.75% 75% 15.38% 22.85%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

@toloudis toloudis marked this pull request as ready for review October 23, 2023 21:17
@toloudis toloudis requested a review from a team as a code owner October 23, 2023 21:17
@toloudis toloudis requested review from meganrm, interim17 and ShrimpCryptid and removed request for a team October 23, 2023 21:17
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Played around in the simularium viewer to check and didn't see any issues.

@interim17
Copy link
Contributor

Don't have the keenest eye for AO but it's running well in the example viewer and website.

@toloudis toloudis merged commit 14756f2 into main Nov 1, 2023
6 checks passed
@toloudis toloudis deleted the fix/orthographic-camera-ssao branch November 1, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark shading in ortho camera mode
3 participants