Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dropbox links #335

Merged
merged 2 commits into from
Oct 11, 2023
Merged

change dropbox links #335

merged 2 commits into from
Oct 11, 2023

Conversation

meganrm
Copy link
Contributor

@meganrm meganrm commented Oct 11, 2023

Problem

Dropbox links to OBJ files started having a CORS error

Solution

I replaced the www.dropbox.com with dl.dropboxusercontent.com
based on this post
They do note in the post that dl.dropboxusercontent.com is an old style that they still support "for now" so we'll have to keep an eye on it. I did ask in the forum if they plan to address the CORS issue with the new link style, so we'll see what they say.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires updated or new tests

Steps to Verify:

  1. npm start
  2. open test bed viewer
  3. drag and drop this file
  4. should see structures

Screenshots (optional):

Screenshot 2023-10-11 at 10 16 41 AM

@meganrm meganrm requested a review from a team as a code owner October 11, 2023 17:17
@meganrm meganrm requested review from toloudis, blairlyons, ShrimpCryptid, interim17, frasercl and ascibisz and removed request for a team October 11, 2023 17:17
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 40.18% 1962/4882
🔴 Branches 43.88% 821/1871
🔴 Functions 37.13% 404/1088
🔴 Lines 40.46% 1880/4646

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

@meganrm meganrm merged commit cd75a2a into main Oct 11, 2023
6 checks passed
@meganrm meganrm deleted the fix/dropbox-links branch October 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants