Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simularium-Engine -> Octopus Code Cleanup #389

Open
3 tasks done
ascibisz opened this issue May 31, 2024 · 0 comments
Open
3 tasks done

Simularium-Engine -> Octopus Code Cleanup #389

ascibisz opened this issue May 31, 2024 · 0 comments
Assignees
Labels
maintenance Code cleanup/refactoring, test coverage, etc.

Comments

@ascibisz
Copy link
Contributor

ascibisz commented May 31, 2024

What needs to happen?

  • We have some redundant code so that the viewer can communicate with both the simularium-engine and octopus. Once we've fully transitioned to octopus, we can strip out simularium-engine specific code. This includes the following:
  • remove the octopus CLI flag and the useOctopus boolean flag, and remove any code that would only be reached when those flags are fals
  • simplify the logic for receiving frame data from net connection, since octopus will always only send one frame at a time
  • update comments
@ascibisz ascibisz added the maintenance Code cleanup/refactoring, test coverage, etc. label May 31, 2024
@ascibisz ascibisz self-assigned this May 31, 2024
@ascibisz ascibisz moved this to 🏃 In Progress in Simularium Planning May 31, 2024
@ascibisz ascibisz moved this from 🏃 In Progress to ✔ Done in Simularium Planning Jun 10, 2024
@ascibisz ascibisz moved this from ✔ Done to 👓 In Review / Blocked in Simularium Planning Jun 10, 2024
@ascibisz ascibisz moved this from 👓 In Review / Blocked to ✔ Done in Simularium Planning Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code cleanup/refactoring, test coverage, etc.
Projects
Archived in project
Development

No branches or pull requests

1 participant