remove redundant function

simularium · Dec 4, 2023 · fb9c7f5 · fb9c7f5
1 parent 5227103
commit fb9c7f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/visGeometry/ColorHandler.ts b/src/visGeometry/ColorHandler.ts
@@ -191,14 +191,9 @@ class ColorHandler {
         };
     }
 
-    public getColorForAgentType(agentType: number): Color {
-        const index = this.getColorIdForAgentType(agentType);
-        return this.getColorById(index);
-    }
-
     public getColorInfoForAgentType(agentType: number): AgentColorInfo {
-        const color = this.getColorForAgentType(agentType);
         const colorId = this.getColorIdForAgentType(agentType);
+        const color = this.getColorById(colorId);
         return { color, colorId };
     }
 }

diff --git a/src/visGeometry/index.ts b/src/visGeometry/index.ts
@@ -1408,7 +1408,7 @@ class VisGeometry {
             this.legacyRenderer.addPdb(
                 pdbEntry,
                 visAgent,
-                this.colorHandler.getColorForAgentType(typeId),
+                this.colorHandler.getColorInfoForAgentType(typeId).color,
                 this.lodDistanceStops
             );
         } else {
@@ -1441,7 +1441,7 @@ class VisGeometry {
                 (meshGeom as Mesh).geometry,
                 visAgent,
                 radius * scale,
-                this.colorHandler.getColorForAgentType(typeId)
+                this.colorHandler.getColorInfoForAgentType(typeId).color
             );
         } else {
             if (meshEntry && meshEntry.instances) {
@@ -1474,7 +1474,7 @@ class VisGeometry {
             this.legacyRenderer.addFiber(
                 visAgent,
                 agentData.cr * scale,
-                this.colorHandler.getColorForAgentType(typeId)
+                this.colorHandler.getColorInfoForAgentType(typeId).color
             );
         } else {
             // update/add to render list