pass down trajTitle for filename

simularium · Nov 15, 2023 · ae96db8 · ae96db8
1 parent 3b8fa9b
commit ae96db8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 55 deletions.
diff --git a/examples/DownloadComponent.tsx b/examples/DownloadComponent.tsx
diff --git a/examples/VideoRecorder.tsx b/examples/VideoRecorder.tsx
@@ -21,7 +21,7 @@ const VideoRecorder = ({ trajectoryTitle }: VideoRecorderProps) => {
         if (canvasEl) {
             recorderRef.current = new Recorder(canvasEl, trajectoryTitle);
         }
-    }, []);
+    }, [trajectoryTitle]);
 
     const startRecording = async () => {
         if (recorderRef.current) {

diff --git a/examples/Viewer.tsx b/examples/Viewer.tsx
@@ -637,11 +637,10 @@ class Viewer extends React.Component<InputParams, ViewerState> {
     }
 
     public getTrajectoryTitle = (): string => {
-        console.log("getTrajectoryTitle", this.state.trajectoryTitle);
         if (this.state.trajectoryTitle) {
             return this.state.trajectoryTitle;
         } else {
-            return "simulation_recording";
+            return "simulation_movie";
         } 
     }
 

diff --git a/src/simularium/StreamRecorder.tsx b/src/simularium/StreamRecorder.tsx
@@ -83,6 +83,9 @@ class Recorder {
             } else {
                 // if recording and the queue is not full, encode the frame and then close it
                 // encoder is passing chunks to muxer
+                // don't entirely understand the use of keyFrames
+                // this is from the docs and will make the resulting video larger but also scrubbable
+                // can optimize/alter these parameters?
                 this.frameCounter++;
                 const keyFrame = this.frameCounter % 150 === 0;
                 this.encoder.encode(frame, { keyFrame });