Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/concentration plot #1

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Feature/concentration plot #1

merged 11 commits into from
Feb 6, 2024

Conversation

meganrm
Copy link
Contributor

@meganrm meganrm commented Jan 25, 2024

Problem

Need to be able to monitor the binding progress to fine tune the settings to reach equilibrium

Solution

Added a plot

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. Note: this needs the main branch of the viewer (we haven't made a new release yet)
  2. Note: this is running with bun
  3. run bun install
  4. run bun dev
  5. press play

Screenshots (optional):

Uploading Screenshot 2024-01-25 at 3.47.36 PM.png…

src/App.tsx Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
@interim17
Copy link
Contributor

LGTM and very cool, I'm excited to see these agent interaction rules getting developed.

@meganrm meganrm requested a review from ShrimpCryptid February 6, 2024 19:04
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a note, I wasn't able to test locally because of some build issues (maybe because bun only has experimental Windows support).

@toloudis
Copy link

toloudis commented Feb 6, 2024

Looks good! Just a note, I wasn't able to test locally because of some build issues (maybe because bun only has experimental Windows support).

I was gonna say at some point, bun is the only technical risk with this. I haven't kept up to see if they are maintaining it well since the first couple of weeks after its release.

currentFrame: number;
agents: InputAgent[] = [];
system: System;
distanceFactor: number;
timeFactor: number;
static: boolean = false;
initialState: boolean = true;
currentNumberBound: number = 0;
onUpdate: (data: number) => void = () => {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference, I think IClientSimulatorImpl should have some API for transmitting plot data back to viewer.

@meganrm
Copy link
Contributor Author

meganrm commented Feb 6, 2024

Looks good! Just a note, I wasn't able to test locally because of some build issues (maybe because bun only has experimental Windows support).

here is the issue tracking windows support that says they're are targeting Feb 16.

@meganrm meganrm merged commit 7152063 into main Feb 6, 2024
@meganrm meganrm deleted the feature/concentration-plot branch February 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants