Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove factory_bot group #6

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove factory_bot group #6

merged 1 commit into from
Nov 27, 2023

Conversation

andyundso
Copy link
Contributor

I noted that pipelines pass again for internal projects which use factory_bot. It seems that the new release v6.4.2 fixed the issues that were introduced with v6.3.0, so I think we can safely remove the separate group from our preset.

I noted that pipelines pass again for internal projects which use `factory_bot`. It seems that the new release v6.4.2 fixed the issues that were introduced with v6.2.0, so I think we can safely remove the separate group from our preset.
Copy link
Member

@Zinggi Zinggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@andyundso andyundso merged commit b701b8b into main Nov 27, 2023
3 checks passed
@andyundso andyundso deleted the revert-factory-bot-group branch November 27, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants