Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler version #2

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Update bundler version #2

merged 3 commits into from
Oct 4, 2023

Conversation

andyundso
Copy link
Contributor

There are two common places in our projects where we can find bundler versions:

  • In the Gemfile.lock
  • In the Dockerfile, where we install bundler.

This PR:

  • Adds a regex manager. that finds the current bundler version for a Gemfile and updates it. Usually, you do this by executing bundle update --bundler, but I do not expect any troubles with directly replacing the version, at least while the lockfile format does not change.
  • Adds in the regexManagers:dockerfileVersions preset. Not sure if a preset can extend another preset, will have to see.

Copy link
Member

@Zinggi Zinggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how safe the regex matcher is to update bundler, but let's try.
Because now renovate will update the lockfile with potentially a different bundler version, right?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Florian Zinggeler <[email protected]>
@andyundso andyundso merged commit f39fd4f into main Oct 4, 2023
3 checks passed
@andyundso andyundso deleted the bundler-update-support branch October 4, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants