Fix detecting test projects #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
Mar 28, 2024
| @@ -2,9 +2,9 @@ | |||
| <!-- Folder layout --> | |||
| <PropertyGroup> | |||
| <IsBenchmarkProject Condition="$(MSBuildProjectName.ToLower().Contains('.benchmarks.'))">true</IsBenchmarkProject> | |||
| <IsTestProject Condition="$(MSBuildProjectName.ToLower().Contains('.tests.'))">true</IsTestProject> | |||
| <IsTestAssetProject Condition="$(MSBuildProjectName.ToLower().Contains('tests.shared.'))">true</IsTestAssetProject> | |||
There was a problem hiding this comment.
Another option would be to prefix all your properties in Directory.Build.props by _. They seem to be used only here.
|
Thanks for this! We've handled it a slightly different way and it seems to be working. Appreciate you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsTestProjectis used by dotnet test VSTest target to detect if a project is or is not a test project. Ensure that we don't mark shared test projects as test projects to avoid running them in a test run because they hold only shared utils, but not any tests.Fix dotnet/sdk#39814
Fix #929