audio/wav not audio/wave, refs #603

simonw · Nov 13, 2024 · 7520671 · 7520671
1 parent 330e171
commit 7520671
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/docs/plugins/advanced-model-plugins.md b/docs/plugins/advanced-model-plugins.md
@@ -79,7 +79,7 @@ def _attachment(attachment):
     if attachment.resolve_type().startswith("image/"):
         return {"type": "image_url", "image_url": {"url": url}}
     else:
-        format_ = "wav" if attachment.resolve_type() == "audio/wave" else "mp3"
+        format_ = "wav" if attachment.resolve_type() == "audio/wav" else "mp3"
         return {
             "type": "input_audio",
             "input_audio": {

diff --git a/docs/usage.md b/docs/usage.md
@@ -305,7 +305,7 @@ OpenAI Chat: gpt-4o-audio-preview
     seed: int
     json_object: boolean
   Attachment types:
-    audio/mpeg, audio/wave
+    audio/mpeg, audio/wav
 OpenAI Chat: gpt-3.5-turbo (aliases: 3.5, chatgpt)
   Options:
     temperature: float

diff --git a/llm/default_plugins/openai_models.py b/llm/default_plugins/openai_models.py
@@ -263,7 +263,7 @@ def _attachment(attachment):
     if attachment.resolve_type().startswith("image/"):
         return {"type": "image_url", "image_url": {"url": url}}
     else:
-        format_ = "wav" if attachment.resolve_type() == "audio/wave" else "mp3"
+        format_ = "wav" if attachment.resolve_type() == "audio/wav" else "mp3"
         return {
             "type": "input_audio",
             "input_audio": {
@@ -327,7 +327,7 @@ def __init__(
         if audio:
             self.attachment_types.update(
                 {
-                    "audio/wave",
+                    "audio/wav",
                     "audio/mpeg",
                 }
             )

diff --git a/tests/test_cli_openai_models.py b/tests/test_cli_openai_models.py
@@ -65,9 +65,8 @@ def test_only_gpt4_audio_preview_allows_mp3_or_wav(httpx_mock, model, filetype):
         method="HEAD",
         url=f"https://www.example.com/example.{filetype}",
         content=b"binary-data",
-        headers={"Content-Type": "audio/mpeg" if filetype == "mp3" else "audio/wave"},
+        headers={"Content-Type": "audio/mpeg" if filetype == "mp3" else "audio/wav"},
     )
-    # Another mock for the correct model
     if model == "gpt-4o-audio-preview":
         httpx_mock.add_response(
             method="POST",
@@ -116,7 +115,7 @@ def test_only_gpt4_audio_preview_allows_mp3_or_wav(httpx_mock, model, filetype):
             url=f"https://www.example.com/example.{filetype}",
             content=b"binary-data",
             headers={
-                "Content-Type": "audio/mpeg" if filetype == "mp3" else "audio/wave"
+                "Content-Type": "audio/mpeg" if filetype == "mp3" else "audio/wav"
             },
         )
     runner = CliRunner()
@@ -140,7 +139,7 @@ def test_only_gpt4_audio_preview_allows_mp3_or_wav(httpx_mock, model, filetype):
         )
     else:
         assert result.exit_code == 1
-        long = "audio/mpeg" if filetype == "mp3" else "audio/wave"
+        long = "audio/mpeg" if filetype == "mp3" else "audio/wav"
         assert (
             f"This model does not support attachments of type '{long}'" in result.output
         )