Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move action for elements #1

Open
wants to merge 4 commits into
base: 4
Choose a base branch
from
Open

Conversation

Jianbinzhu
Copy link
Collaborator

No description provided.

@Jianbinzhu Jianbinzhu force-pushed the features/dev-pull-move-block branch from 906d6d5 to e370d91 Compare August 11, 2023 05:17

const modalSchemaUrl = `${getConfig().form.elementForm.moveModalSchemaUrl}/${id}`;

// Todo: Render modal once per area rather than once per block

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this from module code or your TODO?

null,
$elementID
),
$pageField = TreeDropdownField::create(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit to pages with elemental active

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is done on L62

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to move a block to a page without elemental

@Jianbinzhu Jianbinzhu force-pushed the features/dev-pull-move-block branch from 7759846 to c0aa5d8 Compare August 16, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants