Discoverer v2 support. Spelling suggestions feature #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispenny
force-pushed
the
feature/spelling-suggestion
branch
2 times, most recently
from
cf4ef9e to
4cb0d58
Compare
chrispenny
force-pushed
the
feature/spelling-suggestion
branch
from
4cb0d58 to
20d23c9
Compare
chrispenny
force-pushed
the
feature/spelling-suggestion
branch
from
0d3ee4e to
866e3cf
Compare
blueo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the changes being proposed in Discoverer:
silverstripeltd/silverstripe-discoverer#21
And Discoverer > Elastic Enterprise:
silverstripeltd/silverstripe-discoverer-elastic-enterprise#9
Config change
No practical change here other than updating the injection for the adaptors, but it just felt like it was getting a bit long, and probably deserved some categorisation through separate yaml files.
Breaking changes (summary)
discoverer-bifrosthas been split out into multiple yaml files:discoverer-bifrost-adaptors,discoverer-bifrost-requests, anddiscoverer-bifrost-factoryService/Requests/Search:: __construct())