-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add report generation scripts #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose the report command in https://github.com/silverstripeltd/bespoke-standards/blob/main/composer.json#L16
What do you mean @satrun77 ? FYIW: This is just a quick win for Innovation week. |
534e68f
to
92ae2fb
Compare
@n8-dev is there anything in here that we are waiting for? or is this ready for merge |
I want to look a rebuilding the CLI mechanics to properly support arguments at some point, but having these function as two additional commands for now is good enough, and brings the useful feature into the limelight. I'd say good for an MVP. So yes, ready for merge @satrun77 |
Some reports a easier to read without `-s` being forced in, shift this to be where it needs to be
22f6d4c
to
37563f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP version:
8.0+
Description
Adding two new scripts:
bespoke-phpcs-report-source
bespoke-phpcs-report-summary
Reason for the change
A new usecase from @poyjavier was the ability to see how other PHP code adhears to our coding standards as code review is sometimes a task done.
The ability to do the following
Will vastly streamline things and gives some reference-able data.
Note.
Ability to pass these commands dynamically can be looked at in the future.
Also, this is including the error of passed commands that is present in #27
Plan for Wiki update post merge:
Adjust this section to include new scripts
Adjust exmaple to include new scripts
Final checklist for reviewer
ReadMe updated with Sniff name and link todocs in WikiUnit test(s) addedDisallowed/Allowed code examples added