Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #87

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Methods/CopyMethod.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CopyMethod implements ExposeMethod
*/
protected $filesystem = null;

public function __construct(Filesystem $filesystem = null)
public function __construct(?Filesystem $filesystem = null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily the only changes required were in constructor methods, which we can safely be altered in this way without it actually being a breaking change since constructor method signatures don't have to be identical for subclasses unlike other public methods.

{
$this->filesystem = $filesystem ?: new Filesystem();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Methods/SymlinkMethod.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SymlinkMethod implements ExposeMethod
*/
protected $filesystem = null;

public function __construct(Filesystem $filesystem = null)
public function __construct(?Filesystem $filesystem = null)
{
$this->filesystem = $filesystem ?: new Filesystem();
}
Expand Down