Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add silverstripe/doorman #49

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 5, 2024

Issue silverstripe/.github#350

Needs #49 merged before CI will work

@GuySartorelli
Copy link
Member

Needs #49 merged before CI will work

This is #49... did you mean to put that note in silverstripe/doorman#49 instead?

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't and was never a supported module.
It cannot be in the supportedModules section.

Please move it to "misc"

@emteknetnz
Copy link
Member Author

Have moved

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit b81ae5b into silverstripe:main Dec 9, 2024
7 checks passed
@GuySartorelli GuySartorelli deleted the pulls/main/doorman branch December 9, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants