FIX: Use Hierarchy::prepopulateTreeDataCache() in CMS. #183
Conversation
src/Versioned.php
Outdated
| * @param array $options A map of hints about what should be cached. "numChildrenMethod" and | ||
| * "childrenMethod" are allowed keys. | ||
| */ | ||
| public function onPrepopulateTreeDataCache(DataList $recordList = null, array $options = []) |
There was a problem hiding this comment.
I updated Hierachy::prepopulateTreeDataCache to accept an array of IDs as well as DataList. My rational at the time was that if I'm getting a list of IDs as parameters on a request it sounds counter-intuitive that I should fetch them so I can cache something about them.
Ideally onPrepopulateTreeDataCache should mimic this behavior as well.
There was a problem hiding this comment.
For simplicity, we can probably refactor the whole thing to only receive an ID list.
There was a problem hiding this comment.
actually, scratch that. DataList would be the only way that you could supply a lazily-evaluated list, since we can't use "iterable" as a typehint in PHP 5.6/7.0.
|
If we update the unit test to use the |
Doesn't do anything without silverstripe/silverstripe-framework#8395