API Deprecate renamed validator #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emteknetnz
force-pushed
the
pulls/6/depr-valid
branch
from
1164bea to
bcdf137
Compare
emteknetnz
commented
Dec 3, 2024
| public function __construct() | ||
| { | ||
| Deprecation::noticeWithNoReplacment('5.4.0', 'Will be renamed to SilverStripe\\UserForms\\Form\\\UserFormsRequiredFieldsValidator', Deprecation::SCOPE_CLASS); | ||
| parent::__construct(...func_get_args()); |
There was a problem hiding this comment.
RequiredFields constructor uses func_get_args() https://github.com/silverstripe/silverstripe-framework/blob/5/src/Forms/RequiredFields.php#L31
emteknetnz
force-pushed
the
pulls/6/depr-valid
branch
from
bcdf137 to
3be85ec
Compare
GuySartorelli
requested changes
Dec 4, 2024
| @@ -19,9 +20,17 @@ | |||
| * | |||
| * Required fields will be validated as usual. | |||
| * Conditionally required fields will be validated IF the display rules are satisfied in the submitted dataset. | |||
| * | |||
| * @deprecated 5.4.0 Will be renamed to SilverStripe\UserForms\Form\\UserFormsRequiredFieldsValidator | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated 5.4.0 Will be renamed to SilverStripe\UserForms\Form\\UserFormsRequiredFieldsValidator | |
| * @deprecated 5.4.0 Will be renamed to SilverStripe\UserForms\Form\UserFormsRequiredFieldsValidator |
There was a problem hiding this comment.
If the namespace isn't changing, we can probably just keep the class name? I can't think of another class we've only changed the name for and not the namespace though.
There was a problem hiding this comment.
Its easier to just have the FQCN. Makes it easier for things like automated tooling
emteknetnz
force-pushed
the
pulls/6/depr-valid
branch
from
3be85ec to
5459312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10908