Skip to content

Commit

Permalink
Merge branch '6' into 7.0
Browse files Browse the repository at this point in the history
# Conflicts:
#	code/Model/UserDefinedForm.php
  • Loading branch information
GuySartorelli committed Dec 10, 2024
2 parents 1d227b9 + 184dad7 commit c5df3e2
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion code/Model/EditableCustomRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ protected function getCanCreateContext($args)
}
// Hack in currently edited page if context is missing
if (Controller::has_curr() && Controller::curr() instanceof CMSMain) {
return Controller::curr()->currentPage();
return Controller::curr()->currentRecord();
}

// No page being edited
Expand Down
4 changes: 2 additions & 2 deletions code/Model/EditableFormField.php
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ public function canEdit($member = null)
// This is to restore User Forms 2.x backwards compatibility.
$controller = Controller::curr();
if ($controller && $controller instanceof CMSPageEditController) {
$parent = $controller->getRecord($controller->currentPageID());
$parent = $controller->getRecord($controller->currentRecordID());
// Only allow this behaviour on pages using UserFormFieldEditorExtension, such
// as UserDefinedForm page type.
if ($parent && $parent->hasExtension(UserFormFieldEditorExtension::class)) {
Expand Down Expand Up @@ -572,7 +572,7 @@ protected function getCanCreateContext($args)
}
// Hack in currently edited page if context is missing
if (Controller::has_curr() && Controller::curr() instanceof CMSMain) {
return Controller::curr()->currentPage();
return Controller::curr()->currentRecord();
}

// No page being edited
Expand Down
2 changes: 1 addition & 1 deletion code/Model/Recipient/EmailRecipient.php
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ protected function getCanCreateContext($args)
}
// Hack in currently edited page if context is missing
if (Controller::has_curr() && Controller::curr() instanceof CMSMain) {
return Controller::curr()->currentPage();
return Controller::curr()->currentRecord();
}

// No page being edited
Expand Down
2 changes: 1 addition & 1 deletion code/Model/Recipient/EmailRecipientCondition.php
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ protected function getCanCreateContext($args)
}
// Hack in currently edited page if context is missing
if (Controller::has_curr() && Controller::curr() instanceof CMSMain) {
return Controller::curr()->currentPage();
return Controller::curr()->currentRecord();
}

// No page being edited
Expand Down
1 change: 1 addition & 0 deletions code/Model/UserDefinedForm.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class UserDefinedForm extends Page

/**
* @var string
* @deprecated 6.4.0 Will be renamed to cms_icon_class
*/
private static $icon_class = 'font-icon-p-list';

Expand Down
2 changes: 1 addition & 1 deletion tests/php/Form/GridFieldAddClassesButtonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function testHandleAddUpdatesModifiedFormData()
$request = new HTTPRequest('GET', '/');
$request->setSession(new Session([]));
$controller->setRequest($request);
$controller->setCurrentPageID($udf->ID);
$controller->setCurrentRecordID($udf->ID);
$controller->pushCurrent();
$list = new DataList(EditableFormField::class);
$field = EditableTextField::create([
Expand Down

0 comments on commit c5df3e2

Please sign in to comment.