Merge pull request #1336 from creative-commoners/pulls/7/field-valida…

…tors

MNT Fix unit test

tests/php/Control/UserDefinedFormControllerTest.php

@@ -584,16 +584,41 @@ public function testParseByteSizeStringBadValuesThrowException($input)
     public static function provideValidEmailsToArray()
     {
         return [
-            [[], [null]],
-            [[], [' , , ']],
-            [[], ['broken.email, [email protected], broken2.@email']],
             [
-                ['broken@email', '[email protected]'],
-                [', broken@email, [email protected],[email protected],']
+                'input' => [
+                    null
+                ],
+                'expected' => [],
             ],
             [
-                ['[email protected]', '[email protected]', '[email protected]'],
-                ['[email protected], [email protected], [email protected]']
+                'input' => [
+                    ' , , '
+                ],
+                'expected' => [],
+            ],
+            [
+                'input' => [
+                    'broken.email, [email protected], broken2.@email'
+                ],
+                'expected' => [],
+            ],
+            [
+                'input' => [
+                    ', broken@email, [email protected],[email protected],'
+                ],
+                'expected' => [
+                    '[email protected]'
+                ],
+            ],
+            [
+                'input' => [
+                    '[email protected], [email protected], [email protected]'
+                ],
+                'expected' => [
+                    '[email protected]',
+                    '[email protected]',
+                    '[email protected]'
+                ],
             ]
         ];
     }
@@ -602,14 +627,14 @@ public static function provideValidEmailsToArray()
      * Test that provided email is valid
      */
     #[DataProvider('provideValidEmailsToArray')]
-    public function testValidEmailsToArray(array $expectedOutput, array $input)
+    public function testValidEmailsToArray(array $input, array $expected)
     {
         $class = new ReflectionClass(UserDefinedFormController::class);
         $method = $class->getMethod('validEmailsToArray');
         $method->setAccessible(true);
 
         $controller = new UserDefinedFormController();
 
-        $this->assertEquals($expectedOutput, $method->invokeArgs($controller, $input));
+        $this->assertEquals($expected, $method->invokeArgs($controller, $input));
     }
 }