Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Disable ancestor FieldValidators #311

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Disable ancestor FieldValidators #311

merged 1 commit into from
Dec 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 31, 2024
Closed
2 tasks
@emteknetnz emteknetnz marked this pull request as draft October 31, 2024 23:36
@emteknetnz emteknetnz force-pushed the pulls/4/form-field-valid branch 4 times, most recently from b98a70c to cc230f4 Compare November 13, 2024 00:54
@emteknetnz emteknetnz changed the title ENH Use FieldValidator for FormFields API Disable ancestor FieldValidators Nov 13, 2024
@emteknetnz emteknetnz marked this pull request as ready for review November 14, 2024 22:07
GuySartorelli
GuySartorelli approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sucks these don't have validation but that's what the status quo was before so thus it shall remain

@emteknetnz emteknetnz force-pushed the pulls/4/form-field-valid branch from cc230f4 to 20abd2d Compare November 21, 2024 00:46
@emteknetnz emteknetnz force-pushed the pulls/4/form-field-valid branch from 20abd2d to 8d97a7a Compare November 25, 2024 01:47
GuySartorelli
GuySartorelli approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 195c6bd into silverstripe:4 Dec 2, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/form-field-valid branch December 2, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli