-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Subsites + Fluent = incorrect URL segment #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the config change is safe, but I've not yet tested :)
What happens if fluent is not installed? Does having the |
it should not |
@Midouxx would you be able to retarget/rebase this pull-request to |
I've rebased this onto 2.3 |
Thanks Dan. I'll give this a smoke test later this week then look to merge |
@Midouxx This did not appear to fully work. Possibly a different issue from the one originally linked on issue. When I added a fluent locale, my subsite was no longer appeared in the url segment, e.g. http://subsite.mydomain.test/home became |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have a better idea about issue above before this could be merged
This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now? |
fix for issue Subsites + Fluent = incorrect URL segment on edit #416