Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Subsites + Fluent = incorrect URL segment #444

Closed
wants to merge 1 commit into from

Conversation

mohamedallou
Copy link

@mohamedallou mohamedallou commented Oct 11, 2019

Copy link
Contributor

@NightJar NightJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the config change is safe, but I've not yet tested :)

@emteknetnz
Copy link
Member

What happens if fluent is not installed? Does having the fluentcms in the config file cause any issues?

@dhensby
Copy link
Contributor

dhensby commented Jun 29, 2020

Does having the fluentcms in the config file cause any issues?

it should not

@emteknetnz
Copy link
Member

@Midouxx would you be able to retarget/rebase this pull-request to 2.3 instead of master. Reasons being is that master is what would later become subsites 3.0, while what we'd want to target is 2.3 which would be used for the next patch release of subsites

@dhensby dhensby changed the base branch from master to 2.3 June 30, 2020 08:30
@dhensby
Copy link
Contributor

dhensby commented Jun 30, 2020

I've rebased this onto 2.3

@emteknetnz
Copy link
Member

Thanks Dan. I'll give this a smoke test later this week then look to merge

@emteknetnz
Copy link
Member

@Midouxx

This did not appear to fully work. Possibly a different issue from the one originally linked on issue. When I added a fluent locale, my subsite was no longer appeared in the url segment, e.g.

http://subsite.mydomain.test/home

became

http://mydomain.test/home

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have a better idea about issue above before this could be merged

@emteknetnz
Copy link
Member

This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants