Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Page parentage update fix. #136

Merged
merged 2 commits into from
May 10, 2022
+2 −1
Merged

BUG: Page parentage update fix. #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f73a2de
BUG: Page parentage update fix.
mfendeksilverstripe May 10, 2022
fee52c2
PR fixes.
mfendeksilverstripe May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Extension/Engine/SiteTreePublishingEngine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ public function onAfterPublishRecursive(&$original)
// then this is the equivalent of an un-publish and publish as far as the
// static publisher is concerned
if ($original && (
$original->ParentID !== $this->getOwner()->ParentID
// Intentionally using loose comparison as ParentID may contain either string or integer
$original->ParentID != $this->getOwner()->ParentID
|| $original->URLSegment !== $this->getOwner()->URLSegment
)
) {
Expand Down