DEP Bump minimum version of phpstan #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Dec 19, 2024
There was a problem hiding this comment.
I suspect this is a result of running over both the ClassConstFetch (or other fetch/call) node and the Name node. But probably no worth the time required to resolve it since like you say it's not actually doing any harm.
So long as we continue to catch errors and not have false negatives, I'm okay with it.
emteknetnz
force-pushed
the
pulls/1.2/broken-builds
branch
from
f9788b3 to
c5fc2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#349
Fixes https://github.com/silverstripe/silverstripe-standards/actions/runs/12342606211/job/34442740587
phpstan 1.12.6 seems to cause some things to be double counted, I'm not sure why
At a practical level, there's no real any harm in doing the double counting, and I have no idea how to stop it from happening since phpstan is what's doing the counting.
The other approach here is to simply lock the version to 1.12.5, though I'd prefer to just continue to use a caret. We need to bump the minimum version so that the --prefer-lowest build continues to pass in CI