Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #227

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Security/LogInAuthenticationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function authenticateRequest(HTTPRequest $request)
* @param HTTPRequest|null $request
* @throws InvalidArgumentException
*/
public function logIn(Member $member, $persistent = false, HTTPRequest $request = null)
public function logIn(Member $member, $persistent = false, ?HTTPRequest $request = null)
{
// Fall back to retrieving request from current Controller if available
if ($request === null) {
Expand Down Expand Up @@ -108,7 +108,7 @@ public function logIn(Member $member, $persistent = false, HTTPRequest $request
/**
* @param HTTPRequest $request|null
*/
public function logOut(HTTPRequest $request = null)
public function logOut(?HTTPRequest $request = null)
{
// noop
}
Expand Down
4 changes: 2 additions & 2 deletions src/Security/LogOutAuthenticationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function authenticateRequest(HTTPRequest $request)
* @param bool $persistent
* @param HTTPRequest $request|null
*/
public function logIn(Member $member, $persistent = false, HTTPRequest $request = null)
public function logIn(Member $member, $persistent = false, ?HTTPRequest $request = null)
{
// noop
}
Expand All @@ -41,7 +41,7 @@ public function logIn(Member $member, $persistent = false, HTTPRequest $request
* @param HTTPRequest $request|null
* @throws InvalidArgumentException
*/
public function logOut(HTTPRequest $request = null)
public function logOut(?HTTPRequest $request = null)
{
// Fall back to retrieving request from current Controller if available
if ($request === null) {
Expand Down
Loading