ENH Use getStatusFlags() instead of hardcoded statuses #351
Conversation
| color: #cf3f00; | ||
| background-color: #fff2ea; |
There was a problem hiding this comment.
Rely on styling in admin for colours
| &:not(:last-child) { | ||
| margin-right: 5px; | ||
| } |
There was a problem hiding this comment.
Needs a gap between badges - this value matches the right margin on the title text
| return $this->renderWith([static::class, Link::class]); | ||
| return (string) $this->renderWith([static::class, Link::class]); |
There was a problem hiding this comment.
Unrelated change - my IDE was upset that the return type was string but this returns DBHtmlText - probably just because we're using strict mode here when we don't use it anywhere else.
GuySartorelli
force-pushed
the
pulls/5/status-flags
branch
from
830b957 to
f815bb1
Compare
GuySartorelli
force-pushed
the
pulls/5/status-flags
branch
from
f815bb1 to
287276b
Compare
| }; | ||
|
|
||
| const LinkPickerTitle = ({ | ||
| id, | ||
| title, | ||
| description, | ||
| versionState, | ||
| statusFlags, |
There was a problem hiding this comment.
How is this prop being passed in? There's no corresponding PHP change in this PR?
There was a problem hiding this comment.
Yes there is. See the Link.php file.
https://github.com/silverstripe/silverstripe-linkfield/pull/351/files#diff-10018e9f26d86c4bbc71cb5f4e152ce6566f03cf1f40e9ec606f125371a60ad5R241
Status flags are made generic in silverstripe/silverstripe-framework#11460
This PR uses the new
getStatusFlags()method instead of building hardcoded status flags.Ends up looking something like this (custom flag added by overriding
getStatusFlags())Issue
SiteTreeinCMSMainsilverstripe-cms#2947