Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Resolve deprecation warning in test #332

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli
Copy link
Member Author

Prefer lowest failure is unrelated

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing the setAccessible(true) which should still be required according to this comment

isCliOverride is a private static

Is the linked comment wrong? Or is the unit test just wrong?

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Sep 11, 2024

The comment says

Calling this method on a static property that is not public will return a ReflectionException stating the property does not exist

That's not happening, so it must be false.
It's from 10 years ago, things have likely changed since then

@emteknetnz emteknetnz merged commit 8f02aea into silverstripe:4 Sep 11, 2024
14 of 15 checks passed
@emteknetnz emteknetnz deleted the pulls/4/reflection-deprecation branch September 11, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants