-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Document localising links #273
DOC Document localising links #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick test of this after referencing my notes in the original spike
While has_many looks like it works because, it really doesn't
- Sorting has_many in one locale will unexpectedly sort the links in the other locale which is very unexpected
- Archiving a link does nothing. Try refreshing the page after deleting it.
I stopped testing at this point. I think it's simply a case that "has_many doesn't work"
I disagree - I think that is very expected. I think in most cases you would want the links in the same order for all locales and only change the text. Imagine having to go through all of your locales every time you want to change the order of links - what a nightmare! If developers want to sort the links differently per locale, that is doable but goes beyond the basic scenario I have documented here - people who want that probably are already doing that kind of thing elsewhere in their project as well - but if not, they can read the fluent docs to look for information about how fluent works. I want to avoid duplication of documentation as much as possible.
It archives the specific version you have in that locale. After you refresh, you see the version of the link which is stored in the fallback locale. Notice the title of the link is different before and after archiving in this video: Screencast.from.10-04-24.16.19.02.webmThere are a couple of UX issues here:
Those UX issues are not in the scope of this PR, which is just adding documentation. If you want, I can document these UX issues.
I disagree. As stated above, it seems like there are just a few UX issues that need to be ironed out. |
If we want to say that fluent works correctly, though there's some caveats, and we need to do more work on linkfield to get fluent to work as you think it should, then it's too soon to merge these docs as they are where "fluent has_many works" where IMO it really doesn't I think this one needs to go back in refinement for discussion to work out what we want to do with fluent since it sounds like there's a bunch more work to do. |
You're focusing a lot on |
Description
Documents localising links with fluent.
Note that this won't work unless silverstripe/silverstripe-framework#11195 is also merged. You can work around that by adding this configuration:
Original fluent spike
Issues