DOC Update change log to reference updated migration task #8945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillu
reviewed
Apr 29, 2019
| * File with hotfix applied (SS 4.2.3): `assets/[new-content-hash]/myfile.pdf` (redirects to `assets/myfile.pdf`) | ||
| * File with full fix applied (SS 4.3.x) : `assets/myfile.pdf` (no redirect required) | ||
| * Newly uploaded file with full fix applied: `assets/my-other-file.pdf` (no redirect required) | ||
| * File with hotfix applied (SS 4.2.3): `assets/myfile.pdf` and `assets/[old-content-hash]/myfile.pdf` redirects to `assets/[new-content-hash]/myfile.pdf` |
There was a problem hiding this comment.
The point here was to describe the location of the file on the filesystem, not the different virtual or physical paths which get redirected. Those are two different pieces of info, you can't replace one with the other
chillu
reviewed
Apr 29, 2019
chillu
reviewed
Apr 29, 2019
|
|
||
| #### Can I still choose legacy_filenames=true when starting new upgrades? | ||
|
|
||
| Technically yes, but you need to be aware of the tradeoffs. | ||
| Once the regression has been fixed, we don’t see the need for people to choose this option any more. | ||
| Technically yes, but you need to be aware of the tradeoffs. Once the regression has been fixed, we don’t see the need |
There was a problem hiding this comment.
If that second part is true, the first part is redundant (there are no tradeoffs?)
|
I'm merging this as-is since it's getting pretty crazy with different WIP PRs making changes to the changelog, e.g. #8924. |
chillu
pushed a commit
that referenced
this pull request
Apr 29, 2019
* DOC Update change log to reference updated migration task * Update docs/en/04_Changelogs/4.4.0.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue