Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Add Hierarchy::prepopulate_numchildren_cache() #8380

Merged
merged 12 commits into from
Sep 25, 2018
Merged

NEW: Add Hierarchy::prepopulate_numchildren_cache() #8380

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d81ecb
NEW: Add DB::replace_parameter()
Sep 20, 2018
ac43376
NEW: Add Hierarchy::prepopulate_numchildren_cache()
Sep 18, 2018
574918c
Add a `_complete` flag prepopulate_numchildren_cache
Sep 20, 2018
cc7769a
Write some test for DB::replace_parameter
Sep 21, 2018
dd436f5
Write unit test for testing Hierarchy caching.
Sep 23, 2018
07f9cdc
Switch from preg_split to explode for DB::replace_parameter
Sep 23, 2018
700b5da
Simplify Hierarchy::prepopulate_numchildren_cache
Sep 24, 2018
76f7017
Wrap GroupBy in double quotes for Postgresql
Sep 24, 2018
c352a26
NEW: Add Hierarchy::prepopulateTreeDataCache()
Sep 21, 2018
9ca1f75
Applying feedback from Peer review.
Sep 24, 2018
e4a7c43
Remove DB::replace_parameter
Sep 24, 2018
ff92963
Attach table name the stageChildren where ParentID <> ID clause
Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/ORM/Hierarchy/Hierarchy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,7 @@ public static function prepopulate_numchildren_cache($baseClass, $stage, $idList
'"ParentID"',
"COUNT(DISTINCT $idColumn) AS \"NumChildren\"",
]);
$query->setGroupBy([
"ParentID
"]);
$query->setGroupBy(['"ParentID"']);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to use Convert::symbol2sql("ParentID") here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


$numChildren = $query->execute()->map();
self::$cache_numChildren[$baseClass][$stage] = $numChildren;
Expand Down