Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove code that doesn't belong here #11430

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Oct 17, 2024

This permission isn't added in framework, and doesn't exist if silverstripe/admin isn't installed. It doesn't belong here.
See silverstripe/silverstripe-admin#1837 (comment)

Issue

@GuySartorelli
Copy link
Member Author

@emteknetnz This wasn't merged and there's no comments. Please review this and merge it or request changes.

@emteknetnz emteknetnz merged commit e289ea7 into silverstripe:6 Nov 13, 2024
11 checks passed
@emteknetnz emteknetnz deleted the pulls/6/generic-cmsmain branch November 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants