DEP Replace react-dnd with dnd-kit #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6.0/dnd-kit
branch
6 times, most recently
from
e067ba5 to
6d70016
Compare
GuySartorelli
force-pushed
the
pulls/6.0/dnd-kit
branch
from
6d70016 to
765d049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
react-dndwithdnd-kitwith like-for-like functionality, though there is a visual change.When dragging, the element collapses and the entire element is moved along with the mouse, giving a preview of where the element will be after sorting. This is the same behaviour with other sorting in the CMS (e.g. linkfield, and the
GridFieldOrderableRowscomponent in gridfieldextensions).I haven't implemented sorting with the keyboard like linkfield has because that was non-trivial and isn't functionality that was already available for elemental blocks. Improving accessibility to include sorting by keyboard would be a good next step in a separate card and could be accomplished in a minor release.
Issue