SPIKE Inline validation #1148
Closed
SPIKE Inline validation #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/validation
branch
3 times, most recently
from
6a75c1d to
b95c2c4
Compare
emteknetnz
force-pushed
the
pulls/5/validation
branch
from
b95c2c4 to
1cb48b3
Compare
emteknetnz
commented
Feb 26, 2024
| @@ -34,6 +40,14 @@ const SaveAction = (MenuComponent) => (props) => { | |||
| { type: type.title } | |||
| ); | |||
|
|
|||
| // https://redux-form.com/8.3.0/examples/remotesubmit/ | |||
| submitForm(); | |||
There was a problem hiding this comment.
There was a callback below this to show toast notifications, however I don't see us getting this to work because redux-forms 'submit()' function used for triggering a remote submit isn't thenable nor does it allow for adding a callback or have any other method that allows us to do stuff 'onAfterSuccess / onAfterFailure'
Make me inlined to say that remote submit isn't feasible and we need to put the save/submit button actually on the form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #329
Do not review or merge this
This is just for an investigation
This is the same branch that was used on #1113
Note #1150 is a more up to date version of this - this PR may still be useful because it contains code for doing a remote submit that there's still a chance we may use