Merge pull request #1285 from creative-commoners/pulls/6/php84

API PHP 8.4 compatibility changes
silverstripe · Dec 2, 2024 · 66289a3 · 66289a3
2 parents 3107e55 + ae31970
commit 66289a3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Forms/EditFormFactory.php b/src/Forms/EditFormFactory.php
@@ -29,7 +29,7 @@ class EditFormFactory extends DefaultFormFactory
      */
     const FIELD_NAMESPACE_TEMPLATE = 'PageElements_%d_%s';
 
-    public function getForm(RequestHandler $controller = null, $name = EditFormFactory::DEFAULT_NAME, $context = [])
+    public function getForm(?RequestHandler $controller = null, $name = EditFormFactory::DEFAULT_NAME, $context = [])
     {
         $form = parent::getForm($controller, $name, $context);
 
@@ -44,7 +44,7 @@ public function getForm(RequestHandler $controller = null, $name = EditFormFacto
         return $form;
     }
 
-    protected function getFormFields(RequestHandler $controller = null, $name, $context = [])
+    protected function getFormFields(?RequestHandler $controller, $name, $context = [])
     {
         $fields = parent::getFormFields($controller, $name, $context);
 
@@ -58,7 +58,7 @@ protected function getFormFields(RequestHandler $controller = null, $name, $cont
         return $fields;
     }
 
-    protected function getFormValidator(RequestHandler $controller = null, $name, $context = [])
+    protected function getFormValidator(?RequestHandler $controller, $name, $context = [])
     {
         /** @var CompositeValidator $compositeValidator */
         $compositeValidator = parent::getFormValidator($controller, $name, $context);